Merged
Conversation
jimper
reviewed
Dec 26, 2018
jimper
reviewed
Dec 26, 2018
Change-Id: Ic84b25e49cc41e62f029cced8a4b5ddda849d19a
AnashOommen
reviewed
Dec 28, 2018
| foreach ($response->getResults() as $result) { | ||
| /** @var GenerateKeywordIdeaResult $result */ | ||
| // Note that the competition printed below is enum value. | ||
| // For example, a value of 2 will be returned when the competition is 'LOW'. |
Member
There was a problem hiding this comment.
Thanet, could you pls file a bug against the code generator component to make the rendering of this value better?
Member
Author
There was a problem hiding this comment.
This has been in my radar.
The proto lib will release a util that helps this soon already. It should be launched soon next year.
AnashOommen
reviewed
Dec 28, 2018
| use Google\ApiCore\ApiException; | ||
| use Google\Protobuf\StringValue; | ||
|
|
||
| /** This example generates keyword ideas from a list of seed keywords. */ |
Change-Id: Ifd2f8cd5f47d504394b54798bf818f78511d1d32
jradcliff
requested changes
Jan 8, 2019
| ); | ||
| } | ||
|
|
||
| // Specify the optional arguments of the request as a keywordSeed, UrlSeed, |
Member
There was a problem hiding this comment.
nit: Capitalize 'k' in 'keywordSeed' for consistency
Member
Author
There was a problem hiding this comment.
I rather change the other places in this line to lower case to be consistent with the similar sentences in the other line and with the code.
Change-Id: Iebc8d0de3a864df92cfee80f4d43d3e4a9d48792
jradcliff
approved these changes
Jan 9, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.