Skip to content

chore: remove unnecessary words in the README#487

Merged
sethvargo merged 1 commit intogoogle-github-actions:masterfrom
knanao:fix-readme-versioning
Jan 27, 2022
Merged

chore: remove unnecessary words in the README#487
sethvargo merged 1 commit intogoogle-github-actions:masterfrom
knanao:fix-readme-versioning

Conversation

@knanao
Copy link
Copy Markdown
Contributor

@knanao knanao commented Jan 27, 2022

I removed unnatural words in the README.

@knanao knanao requested a review from a team as a code owner January 27, 2022 15:56
Copy link
Copy Markdown
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the main readme, these other changes look good.

can also pin to a specific version:

```yaml
- uses: 'google-github-actions/setup-gcloud@v0.1.1'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional. We won't be updating the README to point to the latest point release all the time.

Copy link
Copy Markdown
Contributor Author

@knanao knanao Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing. Oh, I see. Sorry for my misunderstanding.
Let me fix the title of PR.

@knanao knanao changed the title docs: fix specific version in versioning example chore: remove unnecessary words Jan 27, 2022
@knanao knanao force-pushed the fix-readme-versioning branch from 7ada3d1 to 8d60e75 Compare January 27, 2022 18:22
@knanao knanao changed the title chore: remove unnecessary words chore: remove unnecessary words in the README Jan 27, 2022
@sethvargo sethvargo enabled auto-merge (squash) January 27, 2022 19:35
Copy link
Copy Markdown
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sethvargo sethvargo merged commit 65591e5 into google-github-actions:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants