Authenticate using the standard --cred-file #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verbanicm
approved these changes
Nov 10, 2022
606a204 to
edc48b8
Compare
This has supported both WIF and SAKE since Nov 2, 2021. This removes the need to parse the key and guess its type, removing a lot of unnecessary code. This changes the API to accept a filepath instead of raw credentials and will require an major version bump.
edc48b8 to
9a87d2f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has supported both WIF and SAKE since Nov 2, 2021. This removes the need to parse the key and guess its type, removing a lot of unnecessary code.
This changes the API to accept a filepath instead of raw credentials and will require an major version bump.
Closes #71