fix(ux): fixed issue with transcribed text not showing after releasing space#26609
fix(ux): fixed issue with transcribed text not showing after releasing space#26609
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user experience issue where transcribed text was failing to appear after releasing the push-to-talk key. By increasing the grace period for draining transcription services and refining how service references are cleared, the system now reliably captures and displays final segments of speech before disconnecting. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the voice mode disconnection logic by moving the transcription service cleanup into the grace period timeout and simplifying event listener conditions. Feedback indicates that the grace period duration has been hardcoded, which ignores user configuration and deviates from the project's practice of defining defaults within the settings schema.
|
Size Change: +39 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
|
@devr0306 Thanks for the fix. Looks like this works for the whisper models and NOT for the Gemini-Live API. Maybe change the description to reflect that? |
Abhijit-2592
left a comment
There was a problem hiding this comment.
LGTM Approved with comments!

Summary
Fixed issue with transcribed text not showing after releasing space for whisper models(not for live Gemini API yet).
Details
Related Issues
Fixes #25495
How to Validate
Enter voice mode for the local whisper models and say something. Release the space key while talking and it should output the words you spoke before releasing.
Pre-Merge Checklist