Skip to content

fix(ci): preserve executable bit for mac binaries#26600

Merged
ruomengz merged 2 commits intomainfrom
sea-release-2
May 6, 2026
Merged

fix(ci): preserve executable bit for mac binaries#26600
ruomengz merged 2 commits intomainfrom
sea-release-2

Conversation

@ruomengz
Copy link
Copy Markdown
Contributor

@ruomengz ruomengz commented May 6, 2026

Summary

This PR ensures that macOS binaries downloaded from GitHub Actions artifacts maintain their executable permissions during the release publishing workflow.

Details

The actions/download-artifact action sometimes fails to properly map and restore macOS file modes (like +x) when extracting onto a Linux file system (which happens when transferring from a macos-latest builder to an ubuntu-latest release runner). This adds a chmod +x step immediately after downloading the binaries to manually guarantee the executable bit is set before zipping them for release.

Related Issues

https://github.com/google-gemini/maintainers-gemini-cli/issues/1649

How to Validate

  1. Run the release workflow.
  2. Download the resulting Mac .zip files from the artifacts or draft release.
  3. Extract the .zip file on a Mac.
  4. Verify the gemini binary has the +x bit set and is directly executable.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@ruomengz ruomengz requested a review from a team as a code owner May 6, 2026 18:30
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the release publishing process by ensuring that macOS binaries retain their executable permissions. By manually applying the necessary file modes before zipping, the workflow now correctly handles cross-platform artifact transfers, preventing issues where binaries would arrive in a non-executable state.

Highlights

  • Binary Permissions: Added explicit chmod +x commands for macOS binaries to ensure they remain executable after being processed in the release workflow.
  • CI/CD Reliability: Addressed an issue where GitHub Actions artifact downloads on Linux runners would strip executable bits from macOS binaries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Size Change: -4 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-7DP53QUW.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-CU65WPCX.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-F334ZGJX.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-GFLFE6T6.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-LTKMPO5I.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-ULSQK5RQ.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-VOTFE6OJ.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-WNHPOQQI.js 0 B -658 kB (removed) 🏆
./bundle/core-CQW7I7GP.js 0 B -48.8 kB (removed) 🏆
./bundle/devtoolsService-GRUSXWI7.js 0 B -28 kB (removed) 🏆
./bundle/gemini-NQRNFRNM.js 0 B -584 kB (removed) 🏆
./bundle/interactiveCli-FKRSGTXQ.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-BIXC7P5O.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-LT4O4KOI.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-2CQLDHUD.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-7NUAEZPA.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-7OFZLGVS.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-GP2XBJD7.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-NIAZCP7C.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-OXSDDNBX.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-ZOZVKQKN.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-ZSZ4XOSQ.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/core-LRSPWM3L.js 48.8 kB +48.8 kB (new file) 🆕
./bundle/devtoolsService-4XSHZ4OP.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-MESYMRR5.js 584 kB +584 kB (new file) 🆕
./bundle/interactiveCli-M54M4VM5.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-2BAZI637.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-YRS4XAFI.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/chunk-VJSUVOZ4.js 1.97 MB 0 B
./bundle/cleanup-W73Q52VV.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-NGHTMHWQ.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-AWPC6QG3.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-DXHXWVET.js 932 B +932 B (new file) 🆕
./bundle/start-UEPUIZSZ.js 652 B +652 B (new file) 🆕

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ensures that macOS binaries are marked as executable before being packaged into release assets. A review comment suggests refactoring the duplicated logic for different architectures into a loop to improve maintainability and adhere to DRY principles.

Comment thread .github/actions/publish-release/action.yml Outdated
Copy link
Copy Markdown
Contributor

@sripasg sripasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you !

@ruomengz ruomengz enabled auto-merge May 6, 2026 18:52
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label May 6, 2026
@ruomengz ruomengz added this pull request to the merge queue May 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 6, 2026
@ruomengz ruomengz added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit feae856 May 6, 2026
27 checks passed
@ruomengz ruomengz deleted the sea-release-2 branch May 6, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACP status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants