feat(cli): add ignoreLocalDotEnv setting to isolate from project .env files#24473
feat(cli): add ignoreLocalDotEnv setting to isolate from project .env files#24473soisyourface wants to merge 5 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues where local project environment variables conflict with the CLI's configuration. By introducing a new advanced setting, users can now isolate the CLI from local .env files, ensuring consistent behavior across different project environments by defaulting to global settings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration setting, ignoreLocalDotEnv, which allows the CLI to bypass local and parent directory .env files in favor of the global ~/.gemini/.env file. The changes include updating the findEnvFile logic to conditionally skip directory traversal, adding the setting to the configuration schema, and providing a unit test to verify the new behavior. I have no feedback to provide.
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
Description
This PR introduces a new setting
advanced.ignoreLocalDotEnv(defaulting tofalse) that allows users to explicitly opt-out of project-specific.envfile loading.When enabled, the CLI bypasses the search for
.envand.gemini/.envfiles in the current workspace and parent directories, and instead falls back directly to the global configuration in~/.gemini/.env.Motivation
As discussed in #2493, the current aggressive loading of local
.envfiles can cause significant issues for developers working in projects (like Rails, Laravel, or Symfony) where local environment variables conflict with the CLI's own configuration (e.g.,GOOGLE_CLOUD_PROJECTorGEMINI_API_KEY).This change provides a clean, settings-based way to ensure that Gemini CLI always uses the user's preferred global environment regardless of the project directory it is running in.
Changes
ignoreLocalDotEnvto theadvancedsettings group.findEnvFileto respect the new setting.settings.test.tsto verify the isolation logic.Verification Results
Verified that:
ignoreLocalDotEnvisfalse(default), local.envfiles are still loaded.ignoreLocalDotEnvistrue, local.envfiles are ignored and global variables are loaded.packages/cli/src/config/settings.test.ts.Fixes #2493
Related to #19663 (provides an alternative isolation strategy)