Skip to content

fix(cli): Hide startup tips until folder trust dialog is resolved #12722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xlakshan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(cli): Hide startup tips until folder trust dialog is resolved #12722

0xlakshan wants to merge 5 commits into from
+8 −6

Conversation

@0xlakshan
Copy link
Contributor

@0xlakshan 0xlakshan commented Nov 7, 2025 •
edited
Loading

Summary

#12184 - This PR updates the AppHeader.tsx section so that the tips section is not rendered while the trust dialog is active. currently, the tips appear underneath the trust prompt, but they aren’t actionable until the dialog is dismissed.

Details

I made the changes as requested in the issue. I also had to take AppHeader out of the <Static> component since it doesn’t support re-renders.

gemini-cli/packages/cli/src/ui/components/MainContent.tsx

Lines 90 to 98 in d6d36c7

return (
<>
<AppHeader key="app-header" version={version} />
<Static key={uiState.historyRemountKey} items={historyItems}>
{(item) => item}
</Static>
{pendingItems}
</>
);

Documentation for <Static/> component in Ink - https://github.com/vadimdemedes/ink?tab=readme-ov-file#static

Related Issues

#12184

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@0xlakshan 0xlakshan marked this pull request as ready for review November 8, 2025 12:52
@0xlakshan 0xlakshan requested a review from a team as a code owner November 8, 2025 12:52
@0xlakshan 0xlakshan changed the title fix(cli): Hide startup tips until trust dialog is resolved fix(cli): Hide startup tips until folder trust dialog is resolved Nov 8, 2025
@0xlakshan
Copy link
Contributor Author

0xlakshan commented Nov 11, 2025

Hey @cornmander , I’ve made the changes you mentioned in the issue. When you get a chance, could you take a look? im open to any feedback or tweaks if needed, thank you!

@gemini-cli gemini-cli bot added status/need-issue Pull requests that need to have an associated issue. priority/p1 Important and should be addressed in the near term. and removed status/need-issue Pull requests that need to have an associated issue. labels Jan 7, 2026
@bdmorgan
Copy link
Collaborator

bdmorgan commented Jan 15, 2026

Hi @0xlakshan, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xlakshan @bdmorgan