fix(patch): cherry-pick 643f2c0 to release/v0.11.1-pr-12300 to patch version v0.11.1 and create version 0.11.2#12335
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request applies a targeted patch to correct an issue where the model router was inadvertently disabled by default when using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick to apply a fix that enables the model router by default for Google login. The change to the default configuration in packages/core/src/config/config.ts is correct. The corresponding test update in packages/core/src/config/config.test.ts is also correct in its logic, but it introduces an inconsistency between the test's description and its implementation, which could be misleading.
| }); | ||
| await config.refreshAuth(AuthType.LOGIN_WITH_GOOGLE); | ||
| expect(config.getUseModelRouter()).toBe(false); | ||
| expect(config.getUseModelRouter()).toBe(true); |
There was a problem hiding this comment.
The test's expectation on this line has been changed to assert that the model router is enabled (true). However, the test's description on line 578 (should disable model router by default for oauth-personal) is now inconsistent with this expectation. To avoid confusion, please update the test description to reflect the new expected behavior, for example: should enable model router by default for oauth-personal.
|
Size Change: -2 B (0%) Total Size: 20.1 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 643f2c0 to patch version v0.11.1 in the stable release to create version 0.11.2.