fix(patch): cherry-pick 643f2c0 to release/v0.12.0-preview.4-pr-12300 to patch version v0.12.0-preview.4 and create version 0.12.0-preview.5#12329
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick to create a new patch version for a preview release. It primarily adjusts the default behavior of the model router configuration, ensuring that it remains enabled for all authentication types, including Google authentication, unless explicitly specified otherwise. This change is reflected in both the core configuration logic and its associated unit tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a cherry-picked patch fix. The main change is in packages/core/src/config/config.ts, where the default behavior for disableModelRouterForAuth is altered. It no longer disables the model router for LOGIN_WITH_GOOGLE by default. The corresponding test in packages/core/src/config/config.test.ts has been updated to align with this new behavior. My review confirms the logic of the change and points out a minor but important maintainability issue in the test file.
|
Size Change: -62 B (0%) Total Size: 20.2 MB ℹ️ View Unchanged
|
174462f
into
release/v0.12.0-preview.4-pr-12300
This PR automatically cherry-picks commit 643f2c0 to patch version v0.12.0-preview.4 in the preview release to create version 0.12.0-preview.5.