-
Notifications
You must be signed in to change notification settings - Fork 13.6k
exit_plan_mode hook regression caused by PR 22737 #25054
Copy link
Copy link
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitypriority/p1Important and should be addressed in the near term.Important and should be addressed in the near term.workstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitypriority/p1Important and should be addressed in the near term.Important and should be addressed in the near term.workstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams
Type
Fields
Give feedbackNo fields configured for Task.
Projects
Status
Closed
What happened?
The current docs suggest using a hook to auto-archive plan files: https://geminicli.com/docs/cli/plan-mode/#example-archive-approved-plans-to-gcs-aftertool
This is no longer possible since
plan_path(abs path) was replaced byplan_filename(a filename like "plan.md") in #22737 . The hook script no longer receives sufficient data to resolve the path to the plan file by itself (based on the input JSON and env vars), unless it resorts to a hack such as parsing thereturnDisplaymessage.What did you expect to happen?
The
exit_plan_modehook script should be able to easily resolve the path to the plan file based on the input JSON.Client information
Client Information
Run
geminito enter the interactive CLI, then run the/aboutcommand.Login information
No response
Anything else we need to know?
No response