Skip to content

fix(cli): theme dialog labels missing for themes ending with Light/Dark #24597

@JayadityaGit

Description

@JayadityaGit

What happened?

In the theme selection dialog, the (Incompatible) and (Matches terminal) labels were inconsistently displayed. Specifically, they were missing for themes whose names already contained "Light" or "Dark" (e.g., "GitHub Light", "Ayu Dark"). This was due to a UI rendering bug in ThemeDialog.tsx that skipped rendering these labels whenever the theme's type was already part of its display name.

What did you expect to happen?

The (Incompatible) and (Matches terminal) labels should be displayed for all themes that meet the criteria, regardless of the theme's name.

Client information

Client Information

OS: Linux
Version: 0.36.0-nightly.20260317.2f90b4653

Login information

N/A

Anything else we need to know?

A fix has been implemented to ensure these labels are rendered correctly for all themes.

Metadata

Metadata

Assignees

Labels

area/coreIssues related to User Interface, OS Support, Core Functionalitytype/bug

Type

No fields configured for Bug.

Projects

Status

Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions