-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Incorrect handling of line endings in ignore file parsers #23891
Copy link
Copy link
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityhelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!priority/p3Backlog - a good idea but not currently a priority.Backlog - a good idea but not currently a priority.type/bug
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityhelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!priority/p3Backlog - a good idea but not currently a priority.Backlog - a good idea but not currently a priority.type/bug
Type
Fields
Give feedbackNo fields configured for Bug.
Projects
Status
Closed
What happened?
The
GitIgnoreParserandIgnoreFileParserclasses do not correctly handle different line endings (LF\n, CRLF\r\n, CR\r) in ignore files like .gitignore and .geminiignore. This can lead to incorrect pattern parsing, especially on Windows.What did you expect to happen?
Ignore files with any line endings are parsed correctly, ignoring line ending differences.
Client information
Client Information
Run
geminito enter the interactive CLI, then run the/aboutcommand.Login information
No response
Anything else we need to know?
No response