-
Notifications
You must be signed in to change notification settings - Fork 13.6k
test(sdk): GeminiCliSession has no unit tests #21895
Copy link
Copy link
Closed
Labels
area/platformIssues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmtIssues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmthelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!priority/p2Important but can be addressed in a future release.Important but can be addressed in a future release.
Metadata
Metadata
Assignees
Labels
area/platformIssues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmtIssues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmthelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!priority/p2Important but can be addressed in a future release.Important but can be addressed in a future release.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Description
packages/sdk/src/session.tsis the core session class in the public SDK (272 lines), but has zero unit tests. Only integration tests exist in the package.What's missing
idgetter behaviorinitialize()idempotencysendStream()basic behaviorProposed fix
Add
packages/sdk/src/session.test.tswith unit tests using mockedConfigfrom@google/gemini-cli-core.