address nit

Adib234 · Adib234 · commit c326d71d2f84 · 2026-04-06T16:05:15.000-04:00
diff --git a/packages/cli/src/ui/components/AskUserDialog.tsx b/packages/cli/src/ui/components/AskUserDialog.tsx
@@ -511,9 +511,15 @@ const ChoiceQuestionView: React.FC<ChoiceQuestionViewProps> = ({
 }) => {
   const keyMatchers = useKeyMatchers();
   const isAlternateBuffer = useAlternateBuffer();
-  const hasAll = question.multiSelect && (question.options?.length ?? 0) > 1;
+
+  const questionOptions = useMemo(
+    () => question.options ?? [],
+    [question.options],
+  );
+
+  const showAllOption = question.multiSelect && questionOptions.length > 1;
   // Calculate total options including 'All' and 'Other' to ensure consistent numbering column width
-  const numOptions = (question.options?.length ?? 0) + (hasAll ? 1 : 0) + 1;
+  const numOptions = questionOptions.length + (showAllOption ? 1 : 0) + 1;
   const numLen = String(numOptions).length;
   const radioWidth = 2; // "● "
   const numberWidth = numLen + 2; // e.g., "1. "
@@ -526,11 +532,6 @@ const ChoiceQuestionView: React.FC<ChoiceQuestionViewProps> = ({
 
   const bufferWidth = availableWidth - horizontalPadding;
 
-  const questionOptions = useMemo(
-    () => question.options ?? [],
-    [question.options],
-  );
-
   // Initialize state from initialAnswer if returning to a previously answered question
   const initialReducerState = useMemo((): ChoiceQuestionState => {
     if (!initialAnswer) {
@@ -725,7 +726,7 @@ const ChoiceQuestionView: React.FC<ChoiceQuestionViewProps> = ({
     );
 
     // Add 'All of the above' for multi-select
-    if (question.multiSelect && questionOptions.length > 1) {
+    if (showAllOption) {
       const allItem: OptionItem = {
         key: 'all',
         label: 'All of the above',
@@ -758,7 +759,7 @@ const ChoiceQuestionView: React.FC<ChoiceQuestionViewProps> = ({
     }
 
     return list;
-  }, [questionOptions, question.multiSelect, customOptionText]);
+  }, [questionOptions, showAllOption, customOptionText, question.multiSelect]);
 
   const handleHighlight = useCallback(
     (itemValue: OptionItem) => {
