Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

fix: Pass along model version in GenerateContentResponse#621

Merged
MarkDaoust merged 5 commits intogoogle-gemini:mainfrom
Annhiluc:main
Nov 26, 2024
Merged

fix: Pass along model version in GenerateContentResponse#621
MarkDaoust merged 5 commits intogoogle-gemini:mainfrom
Annhiluc:main

Conversation

@Annhiluc
Copy link
Contributor

@Annhiluc Annhiluc commented Nov 9, 2024

Description of the change

Pass along model version in GenerateContentResponse.

  • Ran python docs/build_docs.py to update documentation.
  • Ran pytest with no failures.

Motivation

b/378140421

Type of change

Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Annhiluc Annhiluc marked this pull request as ready for review November 9, 2024 00:37
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Nov 9, 2024
@Annhiluc Annhiluc changed the title Main fix: Pass along model version in GenerateContentResponse Nov 9, 2024
MarkDaoust
MarkDaoust suggested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR. Could you revert the generated docs? We'll refresh those with the next release.

MarkDaoust
MarkDaoust suggested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. Tests are failing because the generated client library doesn't have that attribute. So this needs a new release of the client lib before we can merge.

@Annhiluc
Copy link
Contributor Author

Annhiluc commented Nov 11, 2024

Thanks Mark for the review! Reverted docs.

Tests are failing because the generated client library doesn't have that attribute.

To clarify, did I miss adding the model_version somewhere or has the client library already added this attribute and it hasn't been released yet? How can I check on the release of the client lib?

@Annhiluc Annhiluc requested a review from MarkDaoust November 11, 2024 19:36
@MarkDaoust
Copy link
Collaborator

MarkDaoust commented Nov 11, 2024

I need to release a new version and update the dependancies in setup.py.

cl/693090666

@MarkDaoust MarkDaoust merged commit b8772ed into google-gemini:main Nov 26, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Nov 26, 2024
@harupy harupy mentioned this pull request Jan 20, 2025
Merged
39 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Annhiluc @MarkDaoust @vishal-dharm