This repository was archived by the owner on Dec 16, 2025. It is now read-only.
fix: thread-safe discovery API setup (Issues#327)#583
Merged
MarkDaoust merged 1 commit intogoogle-gemini:mainfrom Oct 24, 2024
Merged
Conversation
MarkDaoust
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Added threading support to
FileServiceClientto makediscovery_apithread-local.Motivation
Fixes a threading issue where multiple threads could simultaneously access
self._discovery_api, leading to bugs. Makingdiscovery_apithread-local gives each thread its own instance.Resolves: #327
Type of change
Bug fix
Checklist