This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Expand PIL image support.#523
Merged
MarkDaoust merged 6 commits intogoogle-gemini:mainfrom Aug 27, 2024
Merged
Conversation
Change-Id: Ibc8e091c63d30626f78510156e8c024014dddcca
Change-Id: I49b9ab206ade37a8a5535b21fa7fdf62a0c569d2
Change-Id: I813e8569b91e01a0884b1c2ff75dfa84fcf4a609
Change-Id: I1e4a62bb1e1fade244771027380b8a13f444885d
markmcd
reviewed
Aug 27, 2024
| mime_type = "image/gif" | ||
| else: | ||
| if img.mode != "RGB": | ||
| img = img.convert('RGB') |
Member
There was a problem hiding this comment.
I suspect this will upset black
markmcd
previously approved these changes
Aug 27, 2024
Member
markmcd
left a comment
There was a problem hiding this comment.
Strategy for converting LGTM. Seems straightforward to update if we discover new corner cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves most of it by basically noticing that if an image is created from a file -> turn it back to that file type.
But if it's not created from a file, is it okay to just covert to RGB, or can we do better?
Fixes:#511