Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Remove DiscussService and TextService#512

Merged
MarkDaoust merged 12 commits intogoogle-gemini:mainfrom
shilpakancharla:palm_dep
Aug 22, 2024
Merged

Remove DiscussService and TextService#512
MarkDaoust merged 12 commits intogoogle-gemini:mainfrom
shilpakancharla:palm_dep

Conversation

@shilpakancharla
Copy link
Contributor

@shilpakancharla shilpakancharla commented Aug 19, 2024

Description of the change

We are deprecating the PaLM service, and in part, removing DiscussService and TextService. This is also applies to the DiscussAsyncService as well, and the associated clients.

  1. The following files have been removed:
  • google/generativeai/discuss.py
  • google/generativeai/text.py
  • google/generativeai/types/discuss_types.py
  • tests/test_discuss.py
  • tests/test_discuss_async.py
  • tests/test_text.py
  • docs/api/google/generativeai/chat.md
  • docs/api/google/generativeai/chat_async.md
  • docs/api/google/generativeai/generate_text.md
  • docs/api/google/generativeai/generate_embeddings.md
  1. client.py and test_client.py have been modified to reflect the changes as well.
  2. References to TextServiceClient were removed from answer.py.
  3. Remove reference of TextServiceClient from test_client.py.
  4. Remove anything that doesn't have to do with embeddings from text_types.py.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Aug 19, 2024
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip the markdown files and just regenerate those when the code is done.


from google.generativeai.types import helper_types
from google.generativeai.types import text_types
from google.generativeai.types import model_types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move?

@MarkDaoust
Copy link
Collaborator

The failing test is fixed by: #521

@MarkDaoust MarkDaoust merged commit 7342a62 into google-gemini:main Aug 22, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants