This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Remove DiscussService and TextService#512
Merged
MarkDaoust merged 12 commits intogoogle-gemini:mainfrom Aug 22, 2024
Merged
Conversation
MarkDaoust
suggested changes
Aug 19, 2024
Collaborator
MarkDaoust
left a comment
There was a problem hiding this comment.
We can skip the markdown files and just regenerate those when the code is done.
MarkDaoust
suggested changes
Aug 20, 2024
|
|
||
| from google.generativeai.types import helper_types | ||
| from google.generativeai.types import text_types | ||
| from google.generativeai.types import model_types |
MarkDaoust
reviewed
Aug 22, 2024
MarkDaoust
approved these changes
Aug 22, 2024
Collaborator
|
The failing test is fixed by: #521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
We are deprecating the PaLM service, and in part, removing
DiscussServiceandTextService. This is also applies to theDiscussAsyncServiceas well, and the associated clients.client.pyandtest_client.pyhave been modified to reflect the changes as well.TextServiceClientwere removed fromanswer.py.TextServiceClientfromtest_client.py.text_types.py.