Open
Conversation
Author
|
@superbobry Could you review this PR? |
Author
|
@superbobry I've added --import-mode=importlib to pytest to solve the tests issue. |
Collaborator
|
Thanks @medaminezghal. It looks like the build is still failing unfortunately. |
Author
|
@superbobry The problem is from test process not the build. In my machine when I add PYTHONPATH variable that point to the build/lib.*/tree it works with pytest without the virtual environment, if I use the virtual environment, it won't pass. |
|
also seeing this error over at TorchSim/torch-sim#264 (CI run). would be great to get this merged! |
|
This PR should fix the build. You may even want to update pybind11 to the latest release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the build process occurred by CMake Policy Minimum version by the new CMake version >=4 by updating abseil-cpp and pybind11.
It also add the ability to make user choose between abseil-cpp and pybind11 provided from system or downloaded from repository.
This PR should close this issue.