remove parallel linesearch#1410
Merged
Merged
Conversation
fcfe036 to
a05cf33
Compare
erikfrey
approved these changes
Jun 5, 2026
erikfrey
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, let's add one helpful error for future users.
erikfrey
approved these changes
Jun 5, 2026
erikfrey
left a comment
Collaborator
There was a problem hiding this comment.
OK here's a better idea i think
| sdf_iterations: int | ||
| # warp only fields: | ||
| impratio_invsqrt: array("*", float) | ||
| ls_parallel: bool |
Collaborator
There was a problem hiding this comment.
let's add a custom helper like this for a few versions:
def __post_init__(self):
if self.ls_parallel:
raise TypeError("ls_parallel was removed in bla bla")
@retries.setter
def ls_parallel(self, value):
if value:
raise AttributeError("ls_parallel was removed in bla bla")```a05cf33 to
877f9a4
Compare
erikfrey
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove parallel linesearch