fix overwrite_index: importModules changes#1142
Merged
Paul-Lez merged 2 commits intogoogle-deepmind:mainfrom Oct 23, 2025
Merged
fix overwrite_index: importModules changes#1142Paul-Lez merged 2 commits intogoogle-deepmind:mainfrom
Paul-Lez merged 2 commits intogoogle-deepmind:mainfrom
Conversation
The `overwrite_index.lean` script failed to count attributes after a Lean version bump. This was due to changes in how module imports handle environment extensions, as introduced in leanprover/lean4#7787 . `Lean.withImportModules` no longer loads environment extensions. This commit refactors the `runWithImports` function to use the lower-level `importModulesCore` and `finalizeImport` functions, explicitly setting `loadExts := true` to ensure attributes are loaded and counted correctly.
Paul-Lez
reviewed
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
overwrite_index.leanscript failed to count attributes after a Lean version bump. This was due to changes in how module imports handle environment extensions, as introduced inleanprover/lean4#6325 .
Lean.withImportModulesno longer loads environment extensions. This commit refactors therunWithImportsfunction to use the lower-levelimportModulesCoreandfinalizeImportfunctions, explicitly settingloadExts := trueto ensure attributes are loaded and counted correctly.