feat: prepare jsr publish by easymikey · Pull Request #989 · google/zx

easymikey · 2024-12-14T20:21:16Z

Fixes #980

Description

To support JSR:

create build jsr script
add tests
add return types
add comment for fix publish in future

Tests pass
Appropriate changes to README are included in PR

google-cla · 2024-12-14T20:21:20Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

antongolub · 2024-12-15T11:24:16Z

Hey, @easymikey,

Let's keep the core.ts formatting
CLA is required step

antongolub · 2024-12-15T14:42:45Z

src/core.ts

-              code: () => null,
-              signal: () => null,
-              message: () => ProcessOutput.getErrorMessage(error, self._from)
+            self._resolved = true


Let's keep the formatting for valid git blame.

core.ts

Sorry, I rebase another commit, everything is ok now

easymikey · 2024-12-15T15:42:52Z

@antongolub what do you think about adding test:coverege job to pull request action?

antongolub · 2024-12-15T16:39:34Z

@antongolub what do you think about adding test:coverege job to pull request action?

We've already done.

zx/.github/workflows/test.yml

Line 89 in 14ff473

npm run test:coverage

easymikey · 2024-12-15T17:18:59Z

@antongolub what do you think about adding test:coverege job to pull request action?

We've already done.

zx/.github/workflows/test.yml

Line 89 in 14ff473

npm run test:coverage

Tell me, why are they launched only by the maintainer?

antongolub

Almost done. Just a few suggestions

antongolub · 2024-12-15T17:24:53Z

src/cli.ts

   --help, -h           print help
   --repl               start repl
   --experimental       enables experimental features (deprecated)
-


Let's keep this extra line.

antongolub · 2024-12-15T17:37:36Z

scripts/build-jsr.mjs

+
+import fs from 'node:fs'
+import path from 'node:path'
+const cwd = process.cwd()


Let's use root-based resolve, like here

zx/scripts/build-tests.mjs

Line 22 in 9f15fd4

const root = path.resolve(__dirname, '..')

…into prepare-jsr-publish

antongolub · 2024-12-15T18:12:23Z

scripts/build-jsr.mjs

+)
+
+fs.writeFileSync(
+  path.resolve(cwd, 'jsr.json'),


antongolub · 2024-12-15T18:25:40Z

package.json

@@ -70,6 +70,7 @@
    "pretest": "npm run build",
    "test": "npm run test:size && npm run fmt:check && npm run test:unit && npm run test:types && npm run test:license",


"test": "... && npm run test:jsr"

add jsr.json to .gitignore

Ahhh... its in temp. Ok, nvm

antongolub

lgtm. Thanks for the contribution!

easymikey · 2024-12-15T18:45:47Z

@antongolub Thanks for opportunity and your patience :)

easymikey force-pushed the prepare-jsr-publish branch 2 times, most recently from 4503181 to 0ebd232 Compare December 15, 2024 14:36

antongolub requested changes Dec 15, 2024

View reviewed changes

easymikey changed the title ~~Draft: prepare jsr publish~~ Feat: prepare jsr publish Dec 15, 2024

easymikey force-pushed the prepare-jsr-publish branch 2 times, most recently from 6ad4f65 to aa021be Compare December 15, 2024 15:40

easymikey requested a review from antongolub December 15, 2024 15:43

easymikey force-pushed the prepare-jsr-publish branch from 3040ed4 to aa021be Compare December 15, 2024 16:53

antongolub added the ossln24 label Dec 15, 2024

easymikey force-pushed the prepare-jsr-publish branch from aa021be to 3f6370c Compare December 15, 2024 16:58

Mikhail Avdeev added 3 commits December 15, 2024 20:13

chore: add types and comment to prepare publish to jsr.io

2e3be04

feat: add script to build jsr

fd40a66

test: add test for build jsr

7701870

easymikey force-pushed the prepare-jsr-publish branch from 3f6370c to 7701870 Compare December 15, 2024 17:15

Merge branch 'main' into prepare-jsr-publish

6d4999b

easymikey changed the title ~~Feat: prepare jsr publish~~ feat: prepare jsr publish Dec 15, 2024

antongolub requested changes Dec 15, 2024

View reviewed changes

Mikhail Avdeev and others added 4 commits December 15, 2024 20:50

chore: return extra line

a901a51

chore: replace `process.cwd to import.meta.url

d32aa7d

Merge branch 'prepare-jsr-publish' of https://github.com/easymikey/zx …

3b0501f

…into prepare-jsr-publish

Merge branch 'main' into prepare-jsr-publish

7c03882

antongolub reviewed Dec 15, 2024

View reviewed changes

antongolub approved these changes Dec 15, 2024

View reviewed changes

antongolub merged commit 61c0ed1 into google:main Dec 15, 2024

antongolub mentioned this pull request Dec 15, 2024

test: optimize jsr artifact test #991

Merged

2 tasks

		@@ -70,6 +70,7 @@
		"pretest": "npm run build",
		"test": "npm run test:size && npm run fmt:check && npm run test:unit && npm run test:types && npm run test:license",

Uh oh!

Conversation

easymikey commented Dec 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

google-cla bot commented Dec 14, 2024

Uh oh!

antongolub commented Dec 15, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

easymikey commented Dec 15, 2024

Uh oh!

antongolub commented Dec 15, 2024

Uh oh!

easymikey commented Dec 15, 2024

Uh oh!

antongolub left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antongolub left a comment

Choose a reason for hiding this comment

Uh oh!

easymikey commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

easymikey commented Dec 14, 2024 •

edited

Loading

easymikey commented Dec 15, 2024 •

edited

Loading