Skip to content

feat: getVersion with version from package.json#986

Merged
antongolub merged 6 commits intogoogle:mainfrom
shevnv:expose-version
Dec 18, 2024
Merged

feat: getVersion with version from package.json#986
antongolub merged 6 commits intogoogle:mainfrom
shevnv:expose-version

Conversation

@shevnv
Copy link
Copy Markdown
Contributor

@shevnv shevnv commented Dec 14, 2024 •
edited
Loading

Fixes #971

import {getVersion} from 'zx'

const [major] = (getVersion() || '').split('.').map(Number)
if (major < 6)
  throw new Error('zx >= 6 is required')
  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Copy Markdown
Collaborator

antongolub commented Dec 15, 2024 •
edited
Loading

Hey, @shevnv ,

  1. Let's resolve the version value in place. Or even VERSION like on lodash
  2. CLA acceptance is required

@antongolub
Copy link
Copy Markdown
Collaborator

antongolub commented Dec 16, 2024

@shevnv,
Do you need any help to finalize this?

@antongolub
Copy link
Copy Markdown
Collaborator

antongolub commented Dec 18, 2024

@shevnv,
I'll do the rest, if you dont mind.

@antongolub antongolub merged commit 88b8400 into google:main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antongolub antongolub antongolub approved these changes

Assignees

@shevnv shevnv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: expose version

2 participants

@shevnv @antongolub