fix: handle .nothrow() option in ProcessProcess[AsyncIterator]#1217
Merged
antonmedv merged 1 commit intogoogle:mainfrom Jun 3, 2025
Merged
fix: handle .nothrow() option in ProcessProcess[AsyncIterator]#1217antonmedv merged 1 commit intogoogle:mainfrom
.nothrow() option in ProcessProcess[AsyncIterator]#1217antonmedv merged 1 commit intogoogle:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for the .nothrow() option in both the async iterator and promise-based ProcessPromise API, ensuring that errors are suppressed when requested.
- Introduce a test for async iteration with
.nothrow() - Early-return from the async iterator when
nothrowis enabled - Mirror the change in the compiled CommonJS output and bump the size limit
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/core.test.js | Add tests covering .nothrow() behavior |
| src/core.ts | Add if (this.isNothrow()) return in async iterator |
| build/core.cjs | Replicate the early-return in the compiled output |
| .size-limit.json | Update size limit to reflect the new bundle size |
Comments suppressed due to low confidence (1)
test/core.test.js:1052
- [nitpick] The indentation of this
itblock doesn’t match the surrounding tests. Align it with the existing two-space indent level for consistency.
it('handles .nothrow() correctly', async () => {
Comment on lines
+1094
to
+1097
| { | ||
| const { exitCode } = await $`exit 42`.nothrow() | ||
| assert.equal(exitCode, 42) | ||
| } |
There was a problem hiding this comment.
[nitpick] This extra block ({ ... }) around the first assertion is unnecessary and adds visual noise. Consider removing it to simplify the test.
Suggested change
| { | |
| const { exitCode } = await $`exit 42`.nothrow() | |
| assert.equal(exitCode, 42) | |
| } | |
| const { exitCode } = await $`exit 42`.nothrow() | |
| assert.equal(exitCode, 42) |
antonmedv
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1216