Skip to content

feat: enable stream picking on pipe()#1023

Merged
antongolub merged 3 commits intogoogle:mainfrom
antongolub:pick-stream-on-pipe
Dec 23, 2024
Merged

feat: enable stream picking on pipe()#1023
antongolub merged 3 commits intogoogle:mainfrom
antongolub:pick-stream-on-pipe

Conversation

@antongolub
Copy link
Copy Markdown
Collaborator

Closes #978

  const p = $`echo foo >&2; echo bar`
  const o1 = (await p.pipe.stderr`cat`).toString()
  const o2 = (await p.pipe.stdout`cat`).toString()
  
  assert.equal(o1, 'foo\n')
  assert.equal(o2, 'bar\n')
  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub changed the title feat: enable stream pointing on pipe() feat: enable stream picking on pipe() Dec 23, 2024
@antongolub antongolub requested a review from antonmedv December 23, 2024 15:11
@antongolub antongolub merged commit 999db3d into google:main Dec 23, 2024
@antongolub antongolub deleted the pick-stream-on-pipe branch December 23, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: apply promisifyStream to ProcessPromise exposed streams

2 participants