feat: add recommended Node.js version#1012
Merged
antongolub merged 4 commits intogoogle:mainfrom Dec 21, 2024
Merged
Conversation
antongolub
reviewed
Dec 20, 2024
| "license": "Apache-2.0" | ||
| "license": "Apache-2.0", | ||
| "volta": { | ||
| "node": "22.12.0" |
Collaborator
There was a problem hiding this comment.
can we use just 22 here?
Contributor
Author
There was a problem hiding this comment.
No
I will be uploading an issue soon.
antongolub
reviewed
Dec 20, 2024
docs/contribution.md
Outdated
| * Switch to the recommended version of Node.js | ||
| * If you are using [Node.js version manager](https://github.com/shadowspawn/node-version-usage) supported `.node_version` using it. | ||
| * If you are using Volta, Node.js version will be set automatically from `package.json`. | ||
| * In another case manually install recommended version from `.node_version` file. |
Collaborator
There was a problem hiding this comment.
- Install manually Node.js >= 22
- Delegate the routine to any version manager, that supports
.node_versionconfig - Use Volta, the target version will be set automatically from the
package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add recommended Node.js version for version manager supports
.node_versionand for Volta add package.json field.I have prepared a draft for support
.node_versionfile for voltavolta-cli/volta#1973
Fixes #995