Skip to content

Support derive(TryFromBytes) on packed structs#794

Merged
jswrenn merged 1 commit intomainfrom
tryfrombytes-packed
Jan 19, 2024
Merged

Support derive(TryFromBytes) on packed structs#794
jswrenn merged 1 commit intomainfrom
tryfrombytes-packed

Conversation

@jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Jan 19, 2024

Now that #715 supports unaligned Ptrs, we get support for repr(packed) 'for free' — this commit merely removes the anti-packed check from the derive.

Makes progress towards #5.

Now that #715 supports unaligned `Ptr`s, we get support for
`repr(packed)` 'for free' — this commit merely removes the
anti-`packed` check from the derive.

Makes progress towards #5.
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jswrenn jswrenn added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 3b7a937 Jan 19, 2024
@jswrenn jswrenn deleted the tryfrombytes-packed branch January 19, 2024 17:41
@joshlf joshlf changed the title Support derive(TryFromBytes) on packed structs. Support derive(TryFromBytes) on packed structs Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants