Conversation
Previously, some UI tests had missing imports which caused the corresponding `.stderr` files to be populated with unhelpful "cannot find ..." messages. This is another point in favor of #187 (switching to the `ui-test` crate), which presumably would have made it much less likely for this to slip under the radar.
joshlf
commented
Dec 9, 2023
Comment on lines
-104
to
-106
| <<<<<<< HEAD | ||
| error: only C-like enums can implement FromZeros | ||
| ======= |
Member
Author
There was a problem hiding this comment.
Uh oh. The fact that this slipped through suggests that these tests aren't actually getting validated...
This was referenced Dec 9, 2023
jswrenn
approved these changes
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some UI tests had missing imports which caused the corresponding
.stderrfiles to be populated with unhelpful "cannot find ..." messages. This is another point in favor of #187 (switching to theui-testcrate), which presumably would have made it much less likely for this to slip under the radar.