Skip to content

Prevent external PRs from pushing benchmark data in anneal CI workflow#3430

Merged
joshlf merged 1 commit into
mainfrom
codex/investigate-permissions-issues-in-forked-prs
Jun 3, 2026
Merged

Prevent external PRs from pushing benchmark data in anneal CI workflow#3430
joshlf merged 1 commit into
mainfrom
codex/investigate-permissions-issues-in-forked-prs

Conversation

@joshlf

@joshlf joshlf commented Jun 3, 2026

Copy link
Copy Markdown
Member

Motivation

  • Prevent external pull requests from attempting to push benchmark data to the benchmark-data branch (which they do not have permission to do), avoiding push failures and accidental updates.

Description

  • Change auto-push for the benchmark-action/github-action-benchmark step to a conditional: auto-push: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} and add a comment explaining the restriction.

Testing

  • Validated the modified workflow YAML for syntax correctness and ensured the updated conditional compiles in the workflow; no unit tests were changed or required.

Codex Task

@joshlf joshlf enabled auto-merge June 3, 2026 20:05

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (cf7cf61) to head (5ad38a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3430   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf added this pull request to the merge queue Jun 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 3, 2026
@joshlf joshlf merged commit cacc81c into main Jun 3, 2026
138 checks passed
@joshlf joshlf deleted the codex/investigate-permissions-issues-in-forked-prs branch June 3, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants