Skip to content

[ci] Integrate action-validator into CI and pre-push hooks #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshlf merged 1 commit into from
Nov 24, 2025
Merged

[ci] Integrate action-validator into CI and pre-push hooks #2811

joshlf merged 1 commit into from
Nov 24, 2025

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Nov 24, 2025

Integrate the action-validator tool into our CI pipeline and pre-push hooks. This tool validates GitHub Actions workflow files to ensure they are syntactically correct and follow best practices.

This change adds a new script, ci/check_actions.sh, which runs action-validator on all YAML files in .github/. It also updates the pre-push hook to run this check.

Includes a fix for path matching in the exclusion list, ensuring that excluded files are correctly identified by prefixing them with ./.

@joshlf joshlf requested a review from jswrenn November 24, 2025 03:48
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 24, 2025

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's continuous integration and delivery reliability by introducing automated validation for GitHub Actions workflow files. By integrating the action-validator tool, it ensures that all workflow definitions adhere to proper syntax and established best practices, preventing potential issues before they are merged.

Highlights

  • GitHub Actions Validation: Integrated the action-validator tool into the CI pipeline and pre-push hooks to ensure GitHub Actions workflow files are syntactically correct and follow best practices.
  • New Validation Script: Added a new script, ci/check_actions.sh, responsible for installing action-validator and running it against all YAML files within the .github/ directory.
  • Exclusion List Fix: Implemented a fix for path matching in the action-validator exclusion list, ensuring that excluded files are correctly identified by prefixing their paths with ./.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@joshlf joshlf mentioned this pull request Nov 24, 2025
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully integrates action-validator into the CI process and pre-push hooks by adding a new script ci/check_actions.sh and updating githooks/pre-push. The new script is well-structured, handling installation of the validator, exclusion of specific files, and robustly iterating through workflow files. I have one suggestion to improve the conciseness of the file exclusion logic in ci/check_actions.sh. Otherwise, the changes look good.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (9483f7d) to head (a97a14b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2811   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          20       20           
  Lines        5450     5450           
=======================================
  Hits         4804     4804           
  Misses        646      646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf enabled auto-merge November 24, 2025 15:03
@joshlf joshlf force-pushed the integrate-action-validator branch from e309f6a to 14b58e9 Compare November 24, 2025 15:05
@joshlf joshlf added this pull request to the merge queue Nov 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 24, 2025
@joshlf
[ci] Integrate action-validator into CI and pre-push hooks
a97a14b 
Integrate the `action-validator` tool into our CI pipeline and pre-push
hooks. This tool validates GitHub Actions workflow files to ensure they
are syntactically correct and follow best practices.

This change adds a new script, `ci/check_actions.sh`, which runs
`action-validator` on all YAML files in `.github/`. It also updates
the pre-push hook to run this check.

Includes a fix for path matching in the exclusion list, ensuring
that excluded files are correctly identified by prefixing them with `./`.
@joshlf joshlf force-pushed the integrate-action-validator branch from 14b58e9 to a97a14b Compare November 24, 2025 21:24
@joshlf joshlf enabled auto-merge November 24, 2025 21:24
@joshlf joshlf added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit 31a2dfa Nov 24, 2025
100 checks passed
@joshlf joshlf deleted the integrate-action-validator branch November 24, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jswrenn jswrenn jswrenn approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshlf @codecov-commenter @jswrenn