Add TryFromBytes::try_{ref,mut}_from_{bytes,prefix,suffix}_with_elems by joshlf · Pull Request #1747 · google/zerocopy

joshlf · 2024-09-24T14:36:36Z

Makes progress on #5

codecov-commenter · 2024-09-24T15:04:03Z

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (fbb0f8b) to head (95a8ca7).
Report is 279 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lib.rs	0.00%	59 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   88.01%   87.13%   -0.89%     
==========================================
  Files          16       16              
  Lines        5833     5892      +59     
==========================================
  Hits         5134     5134              
- Misses        699      758      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/lib.rs

jswrenn · 2024-09-24T20:47:30Z

Hit merge when you're satisfied, @joshlf.

joshlf · 2024-09-24T21:03:43Z

src/lib.rs

+        count: usize,
+    ) -> Result<&mut Self, TryCastError<&mut [u8], Self>>
+    where
+        Self: KnownLayout<PointerMetadata = usize> + Immutable,


Remove the Immutable bound?

joshlf · 2024-09-24T21:04:00Z

src/lib.rs

+        count: usize,
+    ) -> Result<(&mut Self, &mut [u8]), TryCastError<&mut [u8], Self>>
+    where
+        Self: KnownLayout<PointerMetadata = usize> + Immutable,


Remove the Immutable bound?

joshlf · 2024-09-24T21:04:12Z

src/lib.rs

+        count: usize,
+    ) -> Result<(&mut [u8], &mut Self), TryCastError<&mut [u8], Self>>
+    where
+        Self: KnownLayout<PointerMetadata = usize> + Immutable,


Remove the Immutable bound?

Makes progress on #5

joshlf · 2024-09-24T21:14:18Z

src/lib.rs

+    /// use zerocopy::*;
+    /// # use zerocopy_derive::*;
+    ///
+    /// #[derive(TryFromBytes, Immutable, KnownLayout)]


Don't derive Immutable here?

joshlf · 2024-09-24T21:14:35Z

src/lib.rs

+    /// # use zerocopy_derive::*;
+    ///
+    /// // The only valid value of this type is the byte `0xC0`
+    /// #[derive(TryFromBytes, KnownLayout, Immutable)]


Don't derive Immutable here?

joshlf · 2024-09-24T21:14:52Z

src/lib.rs

+    /// # use zerocopy_derive::*;
+    ///
+    /// // The only valid value of this type is the byte `0xC0`
+    /// #[derive(TryFromBytes, KnownLayout, Immutable)]


Don't derive Immutable here?

joshlf · 2024-09-24T21:15:04Z

src/lib.rs

+    /// use zerocopy::*;
+    /// # use zerocopy_derive::*;
+    ///
+    /// #[derive(TryFromBytes, Immutable, KnownLayout)]


Don't derive Immutable here?

joshlf · 2024-09-24T21:15:16Z

src/lib.rs

+    /// # use zerocopy_derive::*;
+    ///
+    /// // The only valid value of this type is the byte `0xC0`
+    /// #[derive(TryFromBytes, KnownLayout, Immutable)]


Don't derive Immutable here?

joshlf · 2024-09-24T21:15:28Z

src/lib.rs

+    /// use zerocopy::*;
+    /// # use zerocopy_derive::*;
+    ///
+    /// #[derive(TryFromBytes, Immutable, KnownLayout)]


Don't derive Immutable here?

jswrenn · 2024-09-24T21:17:05Z

All unnecessary Immutable bounds have been excised.

joshlf · 2024-09-24T21:20:41Z

Awesome, queued!

joshlf requested a review from jswrenn September 24, 2024 14:36

jswrenn force-pushed the try-from-bytes-with-elems-methods branch 2 times, most recently from 5cdb8d8 to b0d1b2f Compare September 24, 2024 14:57

jswrenn approved these changes Sep 24, 2024

View reviewed changes

joshlf commented Sep 24, 2024

View reviewed changes

src/lib.rs Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

joshlf mentioned this pull request Sep 24, 2024

0.8 Release Roadmap #671

Closed

87 tasks

jswrenn force-pushed the try-from-bytes-with-elems-methods branch from b0d1b2f to cb103be Compare September 24, 2024 20:44

joshlf commented Sep 24, 2024

View reviewed changes

Add TryFromBytes::try_{ref,mut}_from_{bytes,prefix,suffix}_with_elems

95a8ca7

Makes progress on #5

joshlf commented Sep 24, 2024

View reviewed changes

jswrenn force-pushed the try-from-bytes-with-elems-methods branch from cb103be to 95a8ca7 Compare September 24, 2024 21:15

joshlf enabled auto-merge September 24, 2024 21:20

joshlf added this pull request to the merge queue Sep 24, 2024

Merged via the queue into main with commit b24dfe6 Sep 24, 2024

joshlf deleted the try-from-bytes-with-elems-methods branch September 24, 2024 21:49

Conversation

joshlf commented Sep 24, 2024

Uh oh!

codecov-commenter commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jswrenn commented Sep 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jswrenn commented Sep 24, 2024

Uh oh!

joshlf commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Sep 24, 2024 •

edited

Loading