Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 88.01% 88.32% +0.30%
==========================================
Files 16 16
Lines 5833 5962 +129
==========================================
+ Hits 5134 5266 +132
+ Misses 699 696 -3 ☔ View full report in Codecov by Sentry. |
e6f0ac9 to
5381ede
Compare
Member
|
My plan is to not do the array impls in this PR, but follow up in #1749. |
Collaborator
Author
|
LGTM! |
joshlf
approved these changes
Sep 24, 2024
Member
|
I'm testing this to confirm that it doesn't cause inference issues for Fuchsia in https://fxrev.dev/1127272. |
Member
This has landed successfully. |
Collaborator
Author
|
Wahoo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.