Skip to content

[Ref] Remove unaligned constructors#1723

Merged
joshlf merged 1 commit intomainfrom
remove-unaligned
Sep 22, 2024
Merged

[Ref] Remove unaligned constructors#1723
joshlf merged 1 commit intomainfrom
remove-unaligned

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Sep 21, 2024

Closes #1720

@joshlf joshlf requested a review from jswrenn September 21, 2024 22:40
@joshlf
Copy link
Member Author

joshlf commented Sep 21, 2024

@jswrenn Feel free to review, but I'm going to hold off on merging until the Fuchsia vendor CL passes all of its CQ tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.11%. Comparing base (4426bb2) to head (376dab3).
⚠️ Report is 378 commits behind head on main.

Files with missing lines Patch % Lines
src/deprecated.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
- Coverage   88.61%   88.11%   -0.51%     
==========================================
  Files          16       16              
  Lines        5858     5720     -138     
==========================================
- Hits         5191     5040     -151     
- Misses        667      680      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
Copy link
Member Author

joshlf commented Sep 21, 2024

@jswrenn Feel free to review, but I'm going to hold off on merging until the Fuchsia vendor CL passes all of its CQ tests.

Okay everything is passing other than asan tests, which are always flaky. I'm comfortable merging this. I'll mark as "merge when ready".

@joshlf joshlf enabled auto-merge September 21, 2024 23:59
@joshlf joshlf added this pull request to the merge queue Sep 22, 2024
Merged via the queue into main with commit 2405a94 Sep 22, 2024
@joshlf joshlf deleted the remove-unaligned branch September 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test infallible alignment errors in Fuchsia, then remove Ref unaligned constructors

3 participants