Conversation
jswrenn
approved these changes
Sep 7, 2024
jswrenn
approved these changes
Sep 7, 2024
Since `Ref` implements `Deref`, methods risk conflicting with methods of the same names on the target type. Note that, in #210, we considered applying the same change to `Unalign`. We choose not to do that because most uses of `Unalign` involve types with alignments greater than 1, and for these types, `Unalign` does not implement `Deref`. It's not worth making the API significantly more cumbersome in order to make it easier for this niche use case. Closes #210
2aa28b9 to
8cd0903
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 15 15
Lines 5623 5623
=======================================
Hits 4939 4939
Misses 684 684 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
RefimplementsDeref, methods risk conflicting with methods of the same names on the target type.Note that, in #210, we considered applying the same change to
Unalign. We choose not to do that because most uses ofUnaligninvolve types with alignments greater than 1, and for these types,Unaligndoes not implementDeref. It's not worth making the API significantly more cumbersome in order to make it easier for this niche use case.Closes #210