Skip to content

Detect atomic support using target_has_atomic#1586

Merged
joshlf merged 1 commit intomainfrom
target-has-atomic
Aug 21, 2024
Merged

Detect atomic support using target_has_atomic#1586
joshlf merged 1 commit intomainfrom
target-has-atomic

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Aug 9, 2024 •
edited
Loading

Implements TryFromBytes and FromZeros for AtomicPtr; FromBytes and IntoBytes are blocked by #170.

This is adapted from @josephlr's similar implementation in #1091.

Fixes #1086

@joshlf joshlf requested review from djkoloski and jswrenn August 9, 2024 21:29
@joshlf joshlf mentioned this pull request Aug 9, 2024
Closed
@joshlf joshlf force-pushed the target-has-atomic branch 5 times, most recently from f1c0024 to adca09e Compare August 10, 2024 00:20
@joshlf joshlf removed request for djkoloski and jswrenn August 10, 2024 00:41
@joshlf joshlf marked this pull request as draft August 10, 2024 00:42
@joshlf
Copy link
Member Author

joshlf commented Aug 10, 2024

As-is, this does not put all uses of atomics behind cfgs. There are still uses in lib.rs and util.rs. I'll need to migrate those before this is ready.

Base automatically changed from impl-for-transparent-wrapper-soundness to main August 13, 2024 00:33
@joshlf joshlf force-pushed the target-has-atomic branch 3 times, most recently from df53350 to ea6621a Compare August 16, 2024 23:57
@joshlf joshlf mentioned this pull request Aug 17, 2024
Closed
@joshlf joshlf force-pushed the target-has-atomic branch 2 times, most recently from 3cbe102 to 161a694 Compare August 20, 2024 16:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (e29fb6a) to head (5205f60).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          15       15           
  Lines        5565     5565           
=======================================
  Hits         4881     4881           
  Misses        684      684

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf mentioned this pull request Aug 20, 2024
Closed
@joshlf joshlf force-pushed the target-has-atomic branch 3 times, most recently from 0bc9d36 to c3e7afc Compare August 20, 2024 18:17
@joshlf joshlf marked this pull request as ready for review August 20, 2024 18:23
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@joshlf joshlf force-pushed the target-has-atomic branch from c3e7afc to cbe9f8b Compare August 20, 2024 19:21
@joshlf joshlf enabled auto-merge August 20, 2024 19:22
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@joshlf joshlf force-pushed the target-has-atomic branch from cbe9f8b to 20614e8 Compare August 20, 2024 20:22
@joshlf joshlf enabled auto-merge August 20, 2024 20:23
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@joshlf joshlf force-pushed the target-has-atomic branch from 20614e8 to 866b645 Compare August 20, 2024 20:50
@joshlf joshlf enabled auto-merge August 20, 2024 20:51
@joshlf joshlf force-pushed the target-has-atomic branch 4 times, most recently from 8dc08a2 to 50f3cb6 Compare August 20, 2024 23:36
@joshlf joshlf disabled auto-merge August 20, 2024 23:39
@joshlf joshlf force-pushed the target-has-atomic branch from 50f3cb6 to fd749c2 Compare August 20, 2024 23:41
@joshlf joshlf enabled auto-merge August 20, 2024 23:41
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
@joshlf @josephlr
Detect atomic support using target_has_atomic
5205f60 
Implements `TryFromBytes` and `FromZeros` for `AtomicPtr`; `FromBytes`
and `IntoBytes` are blocked by #170.

This is adapted from @josephlr's similar implementation in #1092.

Fixes #1086

Co-authored-by: Joe Richey <joerichey@google.com>
@joshlf joshlf removed this pull request from the merge queue due to a manual request Aug 20, 2024
@joshlf joshlf force-pushed the target-has-atomic branch from fd749c2 to 5205f60 Compare August 20, 2024 23:54
@joshlf joshlf enabled auto-merge August 20, 2024 23:54
@joshlf joshlf added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 63b380c Aug 21, 2024
@joshlf joshlf deleted the target-has-atomic branch August 21, 2024 00:15
@joshlf joshlf mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure in v0.8.0-alpha.7 on Cortex M

3 participants

@joshlf @codecov-commenter @jswrenn