Conversation
jswrenn
approved these changes
Jul 2, 2024
This also bumps zerocopy-derive's syn dependency to 2.0.46. We don't actually need this for zerocopy-derive. However, in CI, we modify zerocopy-derive to take an "exact" dependency on syn (ie, '=2.0.46' instead of '2.0.46'). One of the transitive dependencies of our `testutil` crate requires syn 2.0.46 or later. We could in principle make CI smart enough to test with both syn versions, but we wouldn't gain much for that complexity - it's easier to just bump the version. Fixes #1085 See also #1481
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 15 15
Lines 5307 5307
=======================================
Hits 4636 4636
Misses 671 671 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1085
See also #1481