Always use manual impl of KnownLayout for Unalign#1476
Merged
Conversation
joshlf
approved these changes
Jul 1, 2024
We should not use `derive(KnownLayout)` on `Unalign`, because the derive is not smart enough to realize that `Unalign<T>` is always sized and thus emits a `KnownLayout` impl bounded on `T: KnownLayout.` This is overly restrictive. Fixes #1162
7c74d19 to
4eae89e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 15 15
Lines 5303 5303
=======================================
Hits 4632 4632
Misses 671 671 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not use
derive(KnownLayout)onUnalign, because the derive is not smart enough to realize thatUnalign<T>is always sized and thus emits aKnownLayoutimpl bounded onT: KnownLayout.This is overly restrictive.Fixes #1162