Relax requirements for deriving FromZeroes on enums#145
Merged
joshlf merged 1 commit intogoogle:mainfrom Nov 15, 2022
Merged
Conversation
a6d84d5 to
e1b9b7c
Compare
Member
Seems reasonable to me! Are we guaranteed that, regardless of representation, the 0 is represented as all 0 bits? That's the only pedantry I can come up with that makes me question the validity of deriving on an enum w/ no explicit repr, but I'm pretty confident that's not a problem. Also, could you update the doc comment on |
Member
|
Oh also: Could you add success tests (not UI tests) in |
Member
e1b9b7c to
bb74666
Compare
joshlf
requested changes
Nov 15, 2022
bb74666 to
8c772c6
Compare
8c772c6 to
e605aa5
Compare
joshlf
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30. @joshlf the wording of the reference seems to imply that we can derive
FromZeroeson enums without an explicit repr. Do you feel comfortable doing that?