Skip to content

Implement traits for atomic types#1028

Merged
joshlf merged 1 commit intomainfrom
transparent-atomics
Mar 7, 2024
Merged

Implement traits for atomic types#1028
joshlf merged 1 commit intomainfrom
transparent-atomics

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Mar 7, 2024

Makes progress on #1009. This commit doesn't implement all traits for AtomicPtr<T>, so there's more work to do.

Makes progress on #1009. This commit doesn't implement all traits for
`AtomicPtr<T>`, so there's more work to do.
@joshlf joshlf force-pushed the transparent-atomics branch from 8a10411 to ee02ee8 Compare March 7, 2024 02:05
@joshlf joshlf marked this pull request as ready for review March 7, 2024 02:05
@joshlf joshlf requested a review from jswrenn March 7, 2024 02:05
@joshlf joshlf enabled auto-merge March 7, 2024 02:07
@joshlf joshlf added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit fe7f030 Mar 7, 2024
@joshlf joshlf deleted the transparent-atomics branch March 7, 2024 02:19
@josephlr
Copy link
Member

josephlr commented Apr 4, 2024

@joshlf it seems like this PR causes AtomicBool to implement FromBytes which is unsound. This is fixed in #1091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants