-
Notifications
You must be signed in to change notification settings - Fork 142
Closed
Labels
blocking-next-releaseThis issue should be resolved before we release on crates.ioThis issue should be resolved before we release on crates.iocompatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breaking
Description
Progress
-
FromBytes::ref_from_prefixinconsistent withFromBytes::from_prefix_with_trailing_elements? - Finalize naming as outlined in Revising the (`Try`)`FromBytes` Conversion Methods in 0.8 #1095
- Consider replacing
with_trailing_elementswithwith_elemsin method names - Finalize all
#[doc(hidden)]pubfunctions/methods - finalize naming or delete - Add methods with old names, marked
#[doc(hidden)]and#[deprecated] - Audit to make sure that all deprecation messages mention the current names (since names have changed somewhat since some
#[deprecated]attributes were added) - Resolve all
TODO(#871)comments - Does the name
Ref::fromcause inference issues since Rust thinks it might beFrom::fromrather than inherent? - Rename
Ref::unaligned_fromtounaligned_from_bytes - Rename
FromBytes::ref_from[_with_elems]toref_from_bytes[_with_elems] - Rename
FromBytes::read_fromtoread_from_bytes? - Audit
TryFromBytesmethods for naming consistency w/FromBytesmethods - Make deprecated
Refmethods returnOptions instead ofResults (ie, consistent with old signatures)?
Details
In the same vein as #253, we should audit our API for:
- Internal consistency
- Consistency with existing conventions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
blocking-next-releaseThis issue should be resolved before we release on crates.ioThis issue should be resolved before we release on crates.iocompatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breaking