-
Notifications
You must be signed in to change notification settings - Fork 142
Closed
Labels
compatibility-nonbreakingChanges that are (likely to be) non-breakingChanges that are (likely to be) non-breakingexperience-mediumThis issue is of medium difficulty, and requires some experienceThis issue is of medium difficulty, and requires some experiencehelp wantedExtra attention is neededExtra attention is needed
Description
Some tests are either marked #[cfg_attr(miri, ignore)] or have parameters set to smaller values under cfg!(miri). Even still, they are often expensive when executed, and it would be good to optimize them to save time in CI.
EDIT: It looks like this and related Miri optimizations are backwards, doing the expensive thing under Miri rather than the cheap thing:
Lines 3389 to 3393 in 524b2e2
| let assert_msg = if cfg!(miri) { | |
| format!("\n{args:?}\nsize:{size}, align:{align}") | |
| } else { | |
| String::new() | |
| }; |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
compatibility-nonbreakingChanges that are (likely to be) non-breakingChanges that are (likely to be) non-breakingexperience-mediumThis issue is of medium difficulty, and requires some experienceThis issue is of medium difficulty, and requires some experiencehelp wantedExtra attention is neededExtra attention is needed