Skip to content

Release 0.14.10#1271

Merged
aomarks merged 7 commits intomainfrom
release
Jan 28, 2025
Merged

Release 0.14.10#1271
aomarks merged 7 commits intomainfrom
release

Conversation

@aomarks
Copy link
Member

@aomarks aomarks commented Jan 28, 2025

Also update dependencies.

@aomarks aomarks requested a review from rictic January 28, 2025 20:38
@aomarks aomarks requested a review from augustjk January 28, 2025 20:58
"tsBuildInfoFile": ".tsbuildinfo",
"composite": true
"composite": true,
"skipLibCheck": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this become necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These and a bunch of similar tsc errors from vscode-jsonrpc

node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:28:5 - error TS2416: Property 'forEach' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any) => void' is not assignable to type '(callbackfn: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any) => void'.
    Types of parameters 'callbackfn' and 'callbackfn' are incompatible.
      Types of parameters 'map' and 'map' are incompatible.
        Type 'LinkedMap<K, V>' is not assignable to type 'Map<K, V>'.
          The types returned by 'entries()' are incompatible between these types.
            Property '[Symbol.dispose]' is missing in type 'IterableIterator<[K, V]>' but required in type 'MapIterator<[K, V]>'.

28     forEach(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any): void;
       ~~~~~~~

@aomarks aomarks merged commit 362a67f into main Jan 28, 2025
20 checks passed
@aomarks aomarks deleted the release branch January 28, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants