Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request to bump the Rust toolchain seems to be on the right track. The changes to accommodate the new toolchain version, especially regarding the panic strategy and feature flags like doc_cfg, are consistent. I have a few suggestions to improve the configuration in .cargo/config.toml for better maintainability and to avoid side effects on debug builds, which then allows for simplifying the build scripts in xtask.
This is a follow-up of google#932.
ia0-review
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #932.