Support checksum of lib/crypto in OpenTitan#935
Merged
ia0 merged 1 commit intogoogle:mainfrom Oct 3, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for checksum calculation for cryptographic keys within the OpenTitan runner, specifically for ECDH operations. This is achieved by adding new checksum methods to key types and exposing a new vendor syscall for tests to trigger checksum updates. The changes are logical, but I've identified a critical issue with method signatures that would prevent compilation, and a medium-severity portability issue in the test code. Addressing these points will improve the correctness and robustness of the implementation.
This was changed by the bump in google#932.
ia0-review
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was changed by the bump in #932.