Fix timezone formatting for RFC1123 on some Android devices.#288
Merged
jpd236 merged 1 commit intogoogle:masterfrom Aug 29, 2019
Merged
Fix timezone formatting for RFC1123 on some Android devices.#288jpd236 merged 1 commit intogoogle:masterfrom
jpd236 merged 1 commit intogoogle:masterfrom
Conversation
Some devices render a SimpleDateFormat string of 'zzz' as 'GMT+00:00' instead of just 'GMT', which violates the specification. Since the only valid timezone is 'GMT', just hardcode it as a constant to be safe. Don't change the parsing flow in case servers are returning timezones other than 'GMT'. Fixes google#287
jjoslin
approved these changes
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices render a SimpleDateFormat string of 'zzz' as 'GMT+00:00'
instead of just 'GMT', which violates the specification. Since the
only valid timezone is 'GMT', just hardcode it as a constant to be
safe.
Fixes #287