Allow Volley.newRequestQueue() to be called on main thread#274
Merged
jpd236 merged 6 commits intogoogle:masterfrom May 30, 2019
Merged
Allow Volley.newRequestQueue() to be called on main thread#274jpd236 merged 6 commits intogoogle:masterfrom
jpd236 merged 6 commits intogoogle:masterfrom
Conversation
…structed lazily (and preferably within the initialize() method which is invoked by CacheDispatcher on a non-UI thread). Currently Volley.newRequestQueue() is causing strict mode violation when called on main thread.
jpd236
requested changes
May 30, 2019
Collaborator
jpd236
left a comment
There was a problem hiding this comment.
Generally this concept looks reasonable to me. Just a small suggestion for simplification.
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the helper method calls context.getCacheDir() synchronously and causes strict mode violation when invoked on main thread. By using a supplier instead we can have it constructed lazily on the dispatcher's thread.