Setting a default image, or an error image, will clear previous images.#243
Merged
jpd236 merged 1 commit intogoogle:masterfrom Nov 29, 2018
Merged
Conversation
The most recent call to the setter will be what determines the default/error image, instead of erroring out on conflicts.
jpd236
approved these changes
Nov 29, 2018
Collaborator
jpd236
left a comment
There was a problem hiding this comment.
I suppose this is reasonable in the case that the NetworkImageView is being recycled, and forcing callers to manually clear before setting is a bit clunky.
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent call to the setter will be what determines the default/error
image, instead of erroring out on conflicts.