fix: request time contains RequestQueue blocking time.#140
fix: request time contains RequestQueue blocking time.#140jpd236 merged 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Interesting find... seems to have been this way since 1.0.0 at least. Doesn't seem useful in its current form because take() will block indefinitely until a request actually gets queued. Note though that despite this, the actual network time is also available via NetworkResponse#networkTimeMs, and I don't think that has an issue like this, though it's only present for requests that actually get a network response. @uhager I know you're using this field - any concerns about this change from your end? If not we should probably take it (and perhaps update the Javadoc for VolleyError#getNetworkTimeMs which is currently non-existent). |
|
I don't think we have ever really looked at the network time for errors, only for responses. |
No description provided.