-
Notifications
You must be signed in to change notification settings - Fork 754
DiskBasedCache uses different inputs for file size #57
Copy link
Copy link
Closed
Milestone
Description
Forking from #52 (comment):
Some parts of DiskBasedCache use the file size as the size of the cache entry, which includes the header overhead. Other parts use the data size which doesn't include the header overhead.
We should make this sane. Some constraints:
- I'd generally prefer we use an accurate size on disk since we advertise the cache as using at most that size, but not including the overhead means we might exceed it.
- It's currently hard to calculate the size prior to writing the entry because we don't know how big the CacheHeader will be. I think it would be technically feasible to calculate this deterministically though given that serialization format is fixed (or at least to estimate it...)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels