Skip to content

ImageContainer#cancelRequest is unsafe to call off the main thread #132

@jpd236

Description

@jpd236

As noted in #130, calling cancelRequest may mutate mBatchedResponses at the same time that it is being read in ImageLoader#batchResponse's inner Runnable, which is queued on a main thread handler.

Need to take a closer look at the thread safety guarantees here and either fix them or add documentation on constraints (e.g. only cancel requests on the main thread).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions